Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI checks for build, test, lint, and dep vulnerabilities #23

Merged
merged 28 commits into from
Jun 15, 2022

Conversation

emostov
Copy link
Contributor

@emostov emostov commented May 23, 2022

Closes #11
Closes #32

All non-ci diff comes from addressing clippy errors.

.github/workflows/audit.yml Outdated Show resolved Hide resolved
@emostov emostov requested a review from jack-kearney May 23, 2022 17:00

name: PR

jobs:
Copy link

@keyz keyz Jun 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense for "Checkout + fetch dependencies" to be a separate job, and have other jobs depend on that? I guess this way we can use Cargo.lock as the key for caching the toolchain and dependencies across CI runs

Copy link
Contributor Author

@emostov emostov Jun 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we could "Checkout + fetch dependencies" and then have subsequent jobs run in the same environment it makes sense because it saves us for having to do it for each. But AFAICT every job runs in its own environment so it won't save us any time but instead just make sure subsequent jobs don't run if it fails?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup every job runs in its own environment, however there's a ~global cache that every job can read/write. I think we can have the "checkout + fetch" job write to the cache, then let other jobs restore the cache: maybe something like this

@emostov emostov merged commit 891bd0e into master Jun 15, 2022
@emostov emostov deleted the zeke-github-actions branch July 12, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add stricter lint levels to all crates & test on all features in CI Add Rust CI PR checks
2 participants